Skip to content

Rename detach() to detached #1745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2023
Merged

Rename detach() to detached #1745

merged 1 commit into from
Jun 9, 2023
+13 −6

Conversation

gibachan
Copy link
Contributor

@gibachan gibachan commented Jun 8, 2023

Resolve #1743 😄

kimdv
kimdv reviewed Jun 8, 2023
View reviewed changes
ahoppen
ahoppen approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Looks good to me.

@ahoppen
Copy link
Member

ahoppen commented Jun 8, 2023

@swift-ci Please test

@ahoppen ahoppen enabled auto-merge June 8, 2023 23:56
@ahoppen ahoppen merged commit fadf844 into swiftlang:main Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimdv kimdv kimdv left review comments

@ahoppen ahoppen ahoppen approved these changes

@DougGregor DougGregor Awaiting requested review from DougGregor DougGregor is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename detach() to detached
3 participants
@gibachan @ahoppen @kimdv