Skip to content

Emit description for SyntaxCollections as doc comments #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2019

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Nov 8, 2019

At the moment we are not emitting the description for SyntaxCollection nodes, even if there is one.

This also adds the description added in swiftlang/swift#28162.

@ahoppen
Copy link
Member Author

ahoppen commented Nov 8, 2019

swiftlang/swift#28162

@swift-ci Please test

@harlanhaskins
Copy link
Contributor

Can you avoid printing the autogenerated comment if there's a description provided?

@ahoppen ahoppen force-pushed the collection-doc-comments branch from a0539e3 to e899242 Compare November 9, 2019 00:36
@ahoppen ahoppen force-pushed the collection-doc-comments branch from e899242 to ed94d87 Compare November 9, 2019 00:37
@ahoppen
Copy link
Member Author

ahoppen commented Nov 9, 2019

Oh, yeah. Changed it.

swiftlang/swift#28162
@swift-ci Please test

@swift-ci
Copy link
Contributor

swift-ci commented Nov 9, 2019

Build failed
Swift Test OS X Platform
Git Sha - a0539e3

Copy link
Contributor

@harlanhaskins harlanhaskins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ahoppen ahoppen merged commit decde25 into swiftlang:master Nov 14, 2019
@ahoppen ahoppen deleted the collection-doc-comments branch November 14, 2019 18:55
adevress pushed a commit to adevress/swift-syntax that referenced this pull request Jan 14, 2024
Allow right paren of enum case decl to be on the same line as the las…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants