Skip to content

[5.9][Macros] Opaque params in expansion functions in macro protocols #1775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2023
Merged

[5.9][Macros] Opaque params in expansion functions in macro protocols #1775

merged 1 commit into from
Jun 16, 2023

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Jun 13, 2023 •
edited
Loading

Cherry-pick #1774 into release/5.9

  • Explanation: In macro evolution proposals, each Macro protocol has static func expansion() requirement that uses several some parameters. But the actual declarations used to use generic parameters instead of some. This change fix that.
  • Scope: Macro implementation
  • Risk: Low, This should be NFC for compilations. SourceKit functionalities e.g. code completion are affected by this.
  • Testing: Current test suite passed
  • Issue: rdar://110733340
  • Reviewer: Ben Barham (@bnbarham)

@rintaro rintaro requested a review from DougGregor as a code owner June 13, 2023 21:27
@rintaro
Copy link
Member Author

rintaro commented Jun 13, 2023

@swift-ci Please test

@rintaro
Copy link
Member Author

rintaro commented Jun 15, 2023

@swift-ci Please test Windows

@rintaro rintaro merged commit 3343fe0 into swiftlang:release/5.9 Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DougGregor DougGregor DougGregor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rintaro @DougGregor