Replace most generated code in SyntaxCollections.swift by default protocol implementations #1787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnbarham
reviewed
Jun 15, 2023
| @@ -173,7 +173,7 @@ extension ExprListSyntax: ExpressibleByArrayLiteral { | |||
| public init(_ elements: [ExprSyntaxProtocol]) { | |||
| self = ExprListSyntax(elements.map { | |||
| ExprSyntax(fromProtocol: $0) | |||
| }) | |||
| } as [ExprSyntax]) | |||
There was a problem hiding this comment.
I think it’s something to do with the initializer being moved to an extension and thus it doesn’t have higher precedence than this initializer that that takes [ExprSyntaxProtocol] anymore. But I haven’t reduced it to a minimal reproducer.
DougGregor
approved these changes
Jun 15, 2023
|
@swift-ci Please test |
ahoppen
force-pushed
the
ahoppen/collection-conformance
branch
from
5d10772 to
3276f80
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
…tocol implementations This has two advantages. 1. It reduces the amout of code in swift-syntax 2. It actually makes all the functions defined in every `SyntaxCollection` accessible for existentials or generics over `SyntaxCollection`.
ahoppen
force-pushed
the
ahoppen/collection-conformance
branch
from
3276f80 to
f8d304c
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has two advantages.
SyntaxCollectionaccessible for existentials or generics overSyntaxCollection.