Skip to content

Delete incremental parse related lit-based tests #1807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2023
Merged

Delete incremental parse related lit-based tests #1807

merged 1 commit into from
Jun 21, 2023

Conversation

StevenWong12
Copy link
Contributor

@StevenWong12 StevenWong12 commented Jun 18, 2023 •
edited
Loading

Since we translate these test cases in #1782, I open this to delete the codes we would not use anymore.

@StevenWong12 StevenWong12 requested a review from ahoppen as a code owner June 18, 2023 07:46
@StevenWong12 StevenWong12 mentioned this pull request Jun 18, 2023
Merged
ahoppen
ahoppen approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wohooo. I like deleting code. Let’s wait with merging this until #1782 is merged.

@kimdv
Copy link
Contributor

kimdv commented Jun 19, 2023

Note to self: Remember this in #1618

@ahoppen
Copy link
Member

ahoppen commented Jun 21, 2023

@swift-ci Please test

@ahoppen ahoppen enabled auto-merge June 21, 2023 07:46
@ahoppen ahoppen merged commit 1076504 into swiftlang:main Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahoppen ahoppen ahoppen approved these changes

@kimdv kimdv kimdv approved these changes

@Bebawy350 Bebawy350 Bebawy350 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@StevenWong12 @kimdv @ahoppen @Bebawy350