-
Notifications
You must be signed in to change notification settings - Fork 440
Generate deprecated children #1817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kimdv
merged 2 commits into
swiftlang:main
from
kimdv:kimdv/1756-generate-deprecated-children
Jun 22, 2023
Merged
Generate deprecated children #1817
kimdv
merged 2 commits into
swiftlang:main
from
kimdv:kimdv/1756-generate-deprecated-children
Jun 22, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
01d238d
to
f0dac20
Compare
ahoppen
reviewed
Jun 20, 2023
...ration/Sources/generate-swiftsyntax/templates/swiftsyntax/SwiftSyntaxCompatibilityFile.swift
Outdated
Show resolved
Hide resolved
...ration/Sources/generate-swiftsyntax/templates/swiftsyntax/SwiftSyntaxCompatibilityFile.swift
Outdated
Show resolved
Hide resolved
.../generate-swiftsyntax/templates/swiftsyntaxbuilder/SwiftSyntaxBuilderCompatibilityFile.swift
Outdated
Show resolved
Hide resolved
.../generate-swiftsyntax/templates/swiftsyntaxbuilder/SwiftSyntaxBuilderCompatibilityFile.swift
Outdated
Show resolved
Hide resolved
...ration/Sources/generate-swiftsyntax/templates/swiftsyntax/SwiftSyntaxCompatibilityFile.swift
Outdated
Show resolved
Hide resolved
bf3ae64
to
eab2e1b
Compare
ahoppen
reviewed
Jun 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor comments, otherwise LGTM.
...erate-swiftsyntax/templates/swiftsyntaxbuilder/RenamedChildrenBuilderCompatibilityFile.swift
Outdated
Show resolved
Hide resolved
CodeGeneration/Sources/generate-swiftsyntax/templates/swiftsyntax/SyntaxNodesFile.swift
Outdated
Show resolved
Hide resolved
...eneration/Sources/generate-swiftsyntax/templates/swiftsyntaxbuilder/BuildableNodesFile.swift
Outdated
Show resolved
Hide resolved
...on/Sources/generate-swiftsyntax/templates/swiftsyntax/RenamedChildrenCompatibilityFile.swift
Outdated
Show resolved
Hide resolved
7345308
to
00675b7
Compare
ahoppen
approved these changes
Jun 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much 🙏🏽
@swift-ci Please test |
@swift-ci Please test Windows |
00675b7
to
dac3f37
Compare
dac3f37
to
c197b4d
Compare
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1756