Skip to content

Generate deprecated children #1817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 22, 2023

Conversation

kimdv
Copy link
Contributor

@kimdv kimdv commented Jun 20, 2023

Resolves #1756

@kimdv kimdv requested a review from ahoppen as a code owner June 20, 2023 09:15
@kimdv kimdv force-pushed the kimdv/1756-generate-deprecated-children branch from 01d238d to f0dac20 Compare June 20, 2023 09:18
@kimdv kimdv force-pushed the kimdv/1756-generate-deprecated-children branch 5 times, most recently from bf3ae64 to eab2e1b Compare June 21, 2023 20:45
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor comments, otherwise LGTM.

@kimdv kimdv force-pushed the kimdv/1756-generate-deprecated-children branch 3 times, most recently from 7345308 to 00675b7 Compare June 22, 2023 11:56
@kimdv kimdv enabled auto-merge June 22, 2023 11:56
@kimdv kimdv requested a review from ahoppen June 22, 2023 11:56
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much 🙏🏽

@ahoppen
Copy link
Member

ahoppen commented Jun 22, 2023

@swift-ci Please test

@ahoppen
Copy link
Member

ahoppen commented Jun 22, 2023

@swift-ci Please test Windows

@kimdv kimdv force-pushed the kimdv/1756-generate-deprecated-children branch from 00675b7 to dac3f37 Compare June 22, 2023 16:56
@kimdv kimdv force-pushed the kimdv/1756-generate-deprecated-children branch from dac3f37 to c197b4d Compare June 22, 2023 16:59
@kimdv
Copy link
Contributor Author

kimdv commented Jun 22, 2023

@swift-ci please test

@kimdv kimdv merged commit 034dca0 into swiftlang:main Jun 22, 2023
@kimdv kimdv deleted the kimdv/1756-generate-deprecated-children branch June 22, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate deprecated children
2 participants