Skip to content

[build-script.py] Provide an option to pass a custom path to the gyb tool #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2019

Conversation

akyrtzi
Copy link
Contributor

@akyrtzi akyrtzi commented Dec 4, 2019

No description provided.

@akyrtzi akyrtzi requested a review from ahoppen December 4, 2019 00:52
@akyrtzi
Copy link
Contributor Author

akyrtzi commented Dec 4, 2019

@swift-ci Please test

Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of setting the global variable, I would rather pass the path to the gyb exec as a function parameter.

@akyrtzi
Copy link
Contributor Author

akyrtzi commented Dec 4, 2019

@swift-ci Please test

@swift-ci
Copy link
Contributor

swift-ci commented Dec 4, 2019

Build failed
Swift Test OS X Platform
Git Sha - 851109c

@akyrtzi akyrtzi merged commit dded1b9 into swiftlang:master Dec 4, 2019
@akyrtzi akyrtzi deleted the custom-gyb-path branch December 4, 2019 21:20
adevress pushed a commit to adevress/swift-syntax that referenced this pull request Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants