Skip to content

Add a glossary to SwiftSyntax #1824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Jun 21, 2023

The glossary doesn’t contain much yet but I feel it’s always good to have such a document because it will make it easy to add additional entries to it as they come up.

rdar://110733511

@ahoppen ahoppen requested a review from bnbarham June 21, 2023 10:55
@ahoppen
Copy link
Member Author

ahoppen commented Jun 21, 2023

@swift-ci Please test

@jpsim
Copy link
Contributor

jpsim commented Jun 21, 2023

Great initiative. In my exposure to SwiftSyntax, I’ve encountered a few terms that come to mind that were initially unclear to me, or meant something slightly different than what I first assumed.

Here are some that come to mind in case you’re looking for inspiration for what could be included in this glossary:

  1. Node
  2. Layout
  3. Members vs Children
  4. Raw syntax
  5. Arena

Copy link
Contributor

@bnbarham bnbarham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alex, nice idea!

@@ -0,0 +1,13 @@
# Glossary

Abbreviations used in SwiftSyntax
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Abbreviations used in SwiftSyntax
Glossary of terms and abbreviations used in SwiftSyntax


To avoid ongoing repetition of common long terms, SwiftSyntax uses a couple of abbreviations that are common in compiler projects.

**Decl** Abbrevation for *Declaration*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Decl** Abbrevation for *Declaration*
**Decl** Abbreviation for *Declaration*


**Decl** Abbrevation for *Declaration*

**Expr** Abbrevation for *Expression*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Expr** Abbrevation for *Expression*
**Expr** Abbreviation for *Expression*

@ahoppen ahoppen force-pushed the ahoppen/glosssary branch from 915fcad to bb3f90c Compare June 22, 2023 11:47
@ahoppen
Copy link
Member Author

ahoppen commented Jun 22, 2023

Thanks for the suggestions @jpsim. I added some more entries to the glossary.

@ahoppen
Copy link
Member Author

ahoppen commented Jun 22, 2023

@swift-ci Please test

@jpsim
Copy link
Contributor

jpsim commented Jun 22, 2023

I added some more entries to the glossary.

Thanks, these are really helpful.

The glossary doesn’t contain much yet but I feel it’s always good to have such a document because it will make it easy to add additional entries to it as they come up.

rdar://110733511
@ahoppen ahoppen force-pushed the ahoppen/glosssary branch from bb3f90c to 2c7bac3 Compare June 22, 2023 20:18
@ahoppen
Copy link
Member Author

ahoppen commented Jun 22, 2023

@swift-ci Please test

@ahoppen ahoppen merged commit ea70e0e into swiftlang:main Jun 23, 2023
@ahoppen ahoppen deleted the ahoppen/glosssary branch June 23, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants