[5.9] Generate grammar doc comments for layout nodes #1836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ahoppen
commented
Jun 23, 2023
ahoppen
commented
- Explanation: Add a Children section to the doc comments of syntax nodes that allows you to see the children of the syntax node at a glance in the source order.
- Scope: Adding doc comments to syntax nodes
- Risk: Zero, only adds comments
- Testing: n/a
- Issue: n/a
- Reviewer: @bnbarham on Generate grammar doc comments for layout nodes #1771
|
@swift-ci Please test |
Generate a `Grammar` and a `Children` section as doc-comments for layout nodes. The `Grammar` section is particularly useful for fairly simple syntax nodes to convey their structure. The `Children` section allows you to see the children of the syntax node at a glance in the source order.
ahoppen
force-pushed
the
ahoppen/5.9/generate-grammar
branch
from
a88c172 to
476b42b
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
bnbarham
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.