Skip to content

Update the list(test cases) of API inconsistencies that need to be modified in CodeGeneration #1844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update the list(test cases) of API inconsistencies that need to be modified in CodeGeneration #1844

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 8 additions & 32 deletions CodeGeneration/Tests/ValidateSyntaxNodes/ValidateSyntaxNodes.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,10 @@ class ValidateSyntaxNodes: XCTestCase {
node: .conventionWitnessMethodAttributeArguments,
message: "child 'WitnessMethodLabel' has a single keyword as its only token choice and should thus be named 'Witness_methodKeyword'"
),
ValidationFailure(
node: .deinitEffectSpecifiers,
message: "child 'AsyncSpecifier' has a single keyword as its only token choice and should thus be named 'AsyncKeyword'"
),
ValidationFailure(
node: .derivativeRegistrationAttributeArguments,
message: "child 'OfLabel' has a single keyword as its only token choice and should thus be named 'OfKeyword'"
Expand All @@ -199,10 +203,6 @@ class ValidateSyntaxNodes: XCTestCase {
node: .genericParameter,
message: "child 'Each' has a single keyword as its only token choice and should thus be named 'EachKeyword'"
),
ValidationFailure(
node: .importDecl,
message: "child 'ImportTok' has a single keyword as its only token choice and should thus be named 'ImportKeyword'"
),
ValidationFailure(node: .isExpr, message: "child 'IsTok' has a single keyword as its only token choice and should thus be named 'IsKeyword'"),
ValidationFailure(
node: .originallyDefinedInArguments,
Expand Down Expand Up @@ -242,10 +242,6 @@ class ValidateSyntaxNodes: XCTestCase {
),
ValidationFailure(node: .unresolvedAsExpr, message: "child 'AsTok' has a single keyword as its only token choice and should thus be named 'AsKeyword'"),
ValidationFailure(node: .unresolvedIsExpr, message: "child 'IsTok' has a single keyword as its only token choice and should thus be named 'IsKeyword'"),

// MARK:
ValidationFailure(node: .arrayExpr, message: "child 'LeftSquare' has a token as its only token choice and should thus be named 'LeftSquareBracket'"),
ValidationFailure(node: .arrayExpr, message: "child 'RightSquare' has a token as its only token choice and should thus be named 'RightSquareBracket'"),
ValidationFailure(node: .arrowExpr, message: "child 'ArrowToken' has a token as its only token choice and should thus be named 'Arrow'"),
ValidationFailure(node: .assignmentExpr, message: "child 'AssignToken' has a token as its only token choice and should thus be named 'Equal'"),
ValidationFailure(node: .attribute, message: "child 'AtSignToken' has a token as its only token choice and should thus be named 'AtSign'"),
Expand All @@ -256,26 +252,10 @@ class ValidateSyntaxNodes: XCTestCase {
message: "child 'OperatorToken' has a token as its only token choice and should thus be named 'BinaryOperator'"
),
ValidationFailure(node: .closureCaptureItem, message: "child 'AssignToken' has a token as its only token choice and should thus be named 'Equal'"),
ValidationFailure(
node: .closureCaptureSignature,
message: "child 'LeftSquare' has a token as its only token choice and should thus be named 'LeftSquareBracket'"
),
ValidationFailure(
node: .closureCaptureSignature,
message: "child 'RightSquare' has a token as its only token choice and should thus be named 'RightSquareBracket'"
),
ValidationFailure(
node: .designatedTypeElement,
message: "child 'LeadingComma' has a comma keyword as its only token choice and should thus be named 'Comma' or 'TrailingComma'"
),
ValidationFailure(
node: .dictionaryExpr,
message: "child 'LeftSquare' has a token as its only token choice and should thus be named 'LeftSquareBracket'"
),
ValidationFailure(
node: .dictionaryExpr,
message: "child 'RightSquare' has a token as its only token choice and should thus be named 'RightSquareBracket'"
),
ValidationFailure(
node: .differentiableAttributeArguments,
message: "child 'DiffKindComma' has a comma keyword as its only token choice and should thus be named 'Comma' or 'TrailingComma'"
Expand Down Expand Up @@ -313,11 +293,11 @@ class ValidateSyntaxNodes: XCTestCase {
ValidationFailure(node: .integerLiteralExpr, message: "child 'Digits' has a token as its only token choice and should thus be named 'IntegerLiteral'"),
ValidationFailure(
node: .keyPathSubscriptComponent,
message: "child 'LeftBracket' has a token as its only token choice and should thus be named 'LeftSquareBracket'"
message: "child 'LeftBracket' has a token as its only token choice and should thus be named 'LeftSquare'"
),
ValidationFailure(
node: .keyPathSubscriptComponent,
message: "child 'RightBracket' has a token as its only token choice and should thus be named 'RightSquareBracket'"
message: "child 'RightBracket' has a token as its only token choice and should thus be named 'RightSquare'"
),
ValidationFailure(node: .labeledStmt, message: "child 'LabelColon' has a token as its only token choice and should thus be named 'Colon'"),
ValidationFailure(node: .layoutRequirement, message: "child 'Size' has a token as its only token choice and should thus be named 'IntegerLiteral'"),
Expand Down Expand Up @@ -395,11 +375,11 @@ class ValidateSyntaxNodes: XCTestCase {
ValidationFailure(node: .stringSegment, message: "child 'Content' has a token as its only token choice and should thus be named 'StringSegment'"),
ValidationFailure(
node: .subscriptExpr,
message: "child 'LeftBracket' has a token as its only token choice and should thus be named 'LeftSquareBracket'"
message: "child 'LeftBracket' has a token as its only token choice and should thus be named 'LeftSquare'"
),
ValidationFailure(
node: .subscriptExpr,
message: "child 'RightBracket' has a token as its only token choice and should thus be named 'RightSquareBracket'"
message: "child 'RightBracket' has a token as its only token choice and should thus be named 'RightSquare'"
),
ValidationFailure(
node: .suppressedType,
Expand Down Expand Up @@ -501,10 +481,6 @@ class ValidateSyntaxNodes: XCTestCase {
node: .precedenceGroupAssociativity,
message: "child 'Value' only has keywords as its token choices and should thus and with 'Keyword'"
),
ValidationFailure(
node: .precedenceGroupRelation,
message: "child 'HigherThanOrLowerThan' only has keywords as its token choices and should thus and with 'Keyword'"
),
]
)
}
Expand Down