Allow rewrite to detach from the node's parent #1851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Ah, we can't detach because we're formatting... That's unfortunate 🤔 |
rintaro
approved these changes
Jun 27, 2023
`MissingMaker` and `MissingNodesBasicFormatter` do not require the returned node to have a parent. Avoid re-creating all the parent nodes in this case by detaching the rewritten node (or rather, not re-attaching it). Resolves rdar://111332992 (swiftlang#1847).
|
@swift-ci please test |
bnbarham
changed the title
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MissingMakerandMissingNodesBasicFormatterdo not require the returned node to have a parent. Avoid re-creating all the parent nodes in this case by detaching the rewritten node (or rather, not re-attaching it).Resolves rdar://111332992 (#1847).