Skip to content

[5.9] Add a compatibility layer for the rename SourceEdit -> IncrementalEdit #1853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Jun 27, 2023

  • Explanation: We renamed SourceEdit to IncrementalEdit. Add a deprecated typealias to keep code that still references SourceEdit compiling
  • Risk: We could get ambiguity warnings if a client imports both SwiftRefactor and SwiftSyntax, both of which define a SourceEdit type. But at the moment, we are relying on clients that still depend on SourceEdit existing.
  • Issue: rdar://111375738
  • Reviewer: @bnbarham

@ahoppen ahoppen requested a review from bnbarham June 27, 2023 07:11
@ahoppen
Copy link
Member Author

ahoppen commented Jun 27, 2023

@swift-ci Please test

@ahoppen ahoppen changed the title Add a compatibility layer for the rename SourceEdit -> IncrementalEdit [5.9] Add a compatibility layer for the rename SourceEdit -> IncrementalEdit Jun 27, 2023
@ahoppen ahoppen force-pushed the ahoppen/5.9/sourceedit-compatibility branch from aa0e372 to a214b0b Compare June 27, 2023 15:00
@ahoppen
Copy link
Member Author

ahoppen commented Jun 27, 2023

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented Jun 27, 2023

@swift-ci Please test Windows

1 similar comment
@ahoppen
Copy link
Member Author

ahoppen commented Jun 27, 2023

@swift-ci Please test Windows

@ahoppen
Copy link
Member Author

ahoppen commented Jun 27, 2023

@swift-ci Please test Windows

@ahoppen ahoppen merged commit a56a8ed into swiftlang:release/5.9 Jun 28, 2023
@ahoppen ahoppen deleted the ahoppen/5.9/sourceedit-compatibility branch June 28, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants