Fix child name validation failures in testSingleTokenChoiceChildNaming
#1854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
kimdv
approved these changes
Jun 27, 2023
Comment on lines
-160
to
+161
| name: "Label", | ||
| name: "AvailabilityLabel", |
There was a problem hiding this comment.
Do we need a deprecatedName here`
There was a problem hiding this comment.
Oh, yes. Thanks for catching it.
ahoppen
force-pushed
the
ahoppen/naming-inconsistencies
branch
from
4149759 to
82e380c
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
1 similar comment
|
@swift-ci Please test Windows |
|
@swift-ci Please test macOS |
bnbarham
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the naming validation found by the
testSingleTokenChoiceChildNamingtest, which is describes as follows:Checks standardized naming of children with a single token choice
*Keyword(e.g.ImportKeyword)LeftParen)I will be opening more PRs like to fix naming inconsistencies over in the next couple of weeks.