Skip to content

Fix child name validation failures found by testMultipleKeywordChoicesNaming #1857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Jun 27, 2023

If a token only has keyword token choices, its name should end with Keyword.

@ahoppen ahoppen requested a review from bnbarham June 27, 2023 18:59
@ahoppen ahoppen requested a review from DougGregor as a code owner June 27, 2023 18:59
@kimdv
Copy link
Contributor

kimdv commented Jun 28, 2023

@swift-ci please test

@ahoppen ahoppen force-pushed the ahoppen/naming-inconsistencies branch from bd3692a to edb8d50 Compare June 28, 2023 08:01
@ahoppen
Copy link
Member Author

ahoppen commented Jun 28, 2023

@swift-ci Please test

@kimdv
Copy link
Contributor

kimdv commented Jun 28, 2023

@swift-ci please test windows

@ahoppen
Copy link
Member Author

ahoppen commented Jul 6, 2023

@swift-ci Please test

@ahoppen ahoppen force-pushed the ahoppen/naming-inconsistencies branch from edb8d50 to c88c3a5 Compare July 7, 2023 10:15
@ahoppen
Copy link
Member Author

ahoppen commented Jul 7, 2023

@swift-ci Please test

@ahoppen ahoppen enabled auto-merge July 7, 2023 10:15
@ahoppen
Copy link
Member Author

ahoppen commented Jul 7, 2023

@swift-ci Please test Windows

1 similar comment
@ahoppen
Copy link
Member Author

ahoppen commented Jul 7, 2023

@swift-ci Please test Windows

@ahoppen ahoppen merged commit 1d36fc2 into swiftlang:main Jul 7, 2023
@ahoppen ahoppen deleted the ahoppen/naming-inconsistencies branch July 7, 2023 16:26
@ahoppen ahoppen mentioned this pull request Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants