[5.9][Macros] Copy MacroSystem and related code to SwiftSyntaxMacroExpansion #1868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
And deperecate the original in SwiftSyntaxMacros module. 'MacroSystem' (i.e. 'SyntaxProtocol.expand(macros:in:)') is a syntactic macro expansion utility for testing macros (i.e. assertMacroExpansion()) It should be moved to `SwiftSyntaxMacroExpansion` module because it's a _expansion_ utility, and should share the same code with other expansion functions including the actual compiler expansion. (cherry picked from commit fabcf50)
rintaro
force-pushed
the
5.9-macros-macrossystem-expansion
branch
from
f4d65fa to
972f60e
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
DougGregor
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #1858 into
release/5.9MacroSystem(i.e.SyntaxProtocol.expand(macros:in:)) is a syntactic macro expansion utility for testing macros (i.e.assertMacroExpansion()) It should be moved toSwiftSyntaxMacroExpansionmodule because it's a expansion utility, and should share the same code with other expansion functions including the actual compiler expansion. To help migration fromSwiftSyntaxMacrostoSwiftSyntaxMacroExpansion, just copy it and deprecate the old one inSwiftSyntaxMacros