[Macros] Pass a list of protocols to conform to when expanding an extension macro.
#1871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the ConformanceMacro protocol to refine ExtensionMacro, and provide a default implementation of ExtensionMacro.expansion that calls the conformance expansion method. This way, conformance macros and extension macros can share the same expansion code path.
hborla
force-pushed
the
refine-extension-macros
branch
2 times, most recently
from
af6de8c to
594209d
Compare
|
@swift-ci please test |
hborla
force-pushed
the
refine-extension-macros
branch
from
17a3337 to
14e02c2
Compare
|
@swift-ci please test |
…parameter to expandAttachedMacro.
…acro to add the 'conformingTo' parameter.
compiler_plugin_basic.swift.
hborla
force-pushed
the
refine-extension-macros
branch
from
14e02c2 to
bf0d394
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows |
|
@swift-ci please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change does two things:
ConformanceMacrorefineExtensionMacrowith a default implementation to help migrate to the new protocol.ExtensionMacro.expansionto indicate which protocols the macro should add a conformance to.