Skip to content

[5.9][Macros] Stop using @_spi for PluginMessage types #1877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Jul 5, 2023

Cherry-pick #1876 into release/5.9

swift repo change swiftlang/swift#67144

  • Explanation: Since #67038 PluginMessage types are marked as @_spi(PluginMessage) which was not necessary, and it caused a failure in a build. Since we don't really need to mark it @_spi, just remove it and make it normal public
  • Scope: Macro plugin messaging
  • Risk: Low. This should be NFC
  • Testing: Passes the current test suite
  • Issue: rdar://111748087
  • Reviewer: Ben Barham (@bnbarham)

This doesn't have to be @_spi.

rdar://111748087
(cherry picked from commit 017bcef)
@rintaro
Copy link
Member Author

rintaro commented Jul 5, 2023

swiftlang/swift#67144
@swift-ci Please test

@rintaro rintaro merged commit 74c980b into swiftlang:release/5.9 Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants