Skip to content

Guard OSLog calls on all platforms, not just macOS #1884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Jul 7, 2023

We only guarded the usage of Logger by an OS version on macOS, not on other Apple platforms. Add those platforms the #available clause as well.

Fixes #1883
rdar://111865186

We only guarded the usage of `Logger` by an OS version on macOS, not on other Apple platforms. Add those platforms the `#available` clause as well.

Fixes swiftlang#1883
rdar://111865186
@ahoppen ahoppen requested a review from bnbarham July 7, 2023 11:01
@ahoppen
Copy link
Member Author

ahoppen commented Jul 7, 2023

@swift-ci Please test

@ahoppen ahoppen merged commit c4b8c2f into swiftlang:main Jul 7, 2023
@ahoppen ahoppen deleted the ahoppen/logger-availability branch July 7, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

logStringInterpolationParsingError() fails to compile when building for swiftUI previews
2 participants