[5.9] Plugin should keep handling the conformance macro role #1891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bnbarham
commented
Jul 7, 2023
bnbarham
commented
- Explanation: New compilers will never send conformance as a role (only extension), but swift-syntax should keep handling them until support for older compilers has dropped.
- Scope: Conformance expansions
- Risk: Low
- Testing: Tested swift-macro-examples with an old compiler and new swift-syntax.
- Issue: rdar://111911487
- Original PR: Plugin should keep handling the conformance macro role #1887
DougGregor
approved these changes
Jul 7, 2023
New compilers will never send conformance as a role (only extension), but we should continue supporting conformance until support for those has dropped. Resolves rdar://111911487. (cherry picked from commit e67a859)
bnbarham
force-pushed
the
provide-extension-type-fallback-cherry
branch
from
f36e802 to
c7a803d
Compare
|
@swift-ci please test |
|
@swift-ci please test windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.