Skip to content

Replace IncrementalParseReusedNodeDelegate with ReusedNodeCallback #1900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2023
Merged

Replace IncrementalParseReusedNodeDelegate with ReusedNodeCallback #1900

merged 1 commit into from
Jul 13, 2023

Conversation

StevenWong12
Copy link
Contributor

@StevenWong12 StevenWong12 requested a review from ahoppen as a code owner July 12, 2023 08:37
ahoppen
ahoppen reviewed Jul 12, 2023
View reviewed changes
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much simpler

@StevenWong12 StevenWong12 force-pushed the replace_delegate_with_closure branch from 9343496 to 0e5a32e Compare July 12, 2023 12:37
@ahoppen
Copy link
Member

ahoppen commented Jul 13, 2023

@swift-ci Please test

@ahoppen ahoppen merged commit e71453d into swiftlang:main Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahoppen ahoppen ahoppen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StevenWong12 @ahoppen