Enable some skipped tests in IncrementalParsingTests.swift
#1905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
reviewed
Jul 14, 2023
Sources/_SwiftSyntaxTestSupport/IncrementalParseTestUtils.swift
Outdated
Show resolved
Hide resolved
Sources/_SwiftSyntaxTestSupport/IncrementalParseTestUtils.swift
Outdated
Show resolved
Hide resolved
Also make some naming improvements
StevenWong12
force-pushed
the
enable_skipping_tests
branch
from
c816a99 to
8b77cb6
Compare
ahoppen
approved these changes
Jul 17, 2023
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we now enable re-using on
codeBlockItem, I think we should not skip these test but modify thereusedNodesfor these test cases.To let this happen, I also made some tiny changes on
assertIncrementalParseto make theByteSourceRangecorrectly match in test cases have same substring in source. e.g.Also make some naming improvements:
getEditsAndSources()->extractEditsAndSources(from: source)getByteSourceRange->byteSourceRange