Skip to content

Add validation that all syntax collections end with ListSyntax #1913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 24, 2023
Merged

Add validation that all syntax collections end with ListSyntax #1913

merged 3 commits into from
Jul 24, 2023

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Jul 17, 2023

This didn’t catch anything but it’s a validation I wanted to add.

@ahoppen ahoppen requested a review from bnbarham July 17, 2023 14:08
@ahoppen
Copy link
Member Author

ahoppen commented Jul 17, 2023

@swift-ci Please test

bnbarham
bnbarham approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@bnbarham bnbarham left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This didn’t catch anything but it’s a validation I wanted to add.

Does that mean you don't prefer ListSyntax for eg. EffectsArgumentsSyntax and StringLiteralSegments? Say EffectsArgumentListSyntax and StringSegmentListSyntax?

@ahoppen ahoppen force-pushed the ahoppen/validate-listsyntax branch from 90e5584 to d796fb7 Compare July 18, 2023 21:19
@ahoppen
Copy link
Member Author

ahoppen commented Jul 18, 2023

Actually, I just thought about it again and decided to rename all other collections (except UnexpectedNodes) to also have List suffix for consistency.

@ahoppen
Copy link
Member Author

ahoppen commented Jul 18, 2023

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented Jul 18, 2023

@swift-ci Please test Windows

@ahoppen ahoppen force-pushed the ahoppen/validate-listsyntax branch from d796fb7 to e8c92b1 Compare July 22, 2023 04:52
@ahoppen
Copy link
Member Author

ahoppen commented Jul 22, 2023

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented Jul 22, 2023

@swift-ci Please test Windows

@ahoppen ahoppen force-pushed the ahoppen/validate-listsyntax branch from e8c92b1 to 3346352 Compare July 23, 2023 03:19
@ahoppen
Copy link
Member Author

ahoppen commented Jul 23, 2023

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented Jul 23, 2023

@swift-ci Please test Windows

@ahoppen ahoppen force-pushed the ahoppen/validate-listsyntax branch from 3346352 to 41435de Compare July 23, 2023 15:34
@ahoppen
Copy link
Member Author

ahoppen commented Jul 23, 2023

swiftlang/swift-stress-tester#243

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented Jul 23, 2023

swiftlang/swift-stress-tester#243

@swift-ci Please test Windows

@ahoppen
Copy link
Member Author

ahoppen commented Jul 24, 2023

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented Jul 24, 2023

@swift-ci Please test Windows

@ahoppen ahoppen merged commit 2e8bff5 into swiftlang:main Jul 24, 2023
@ahoppen ahoppen deleted the ahoppen/validate-listsyntax branch July 24, 2023 15:54
@ahoppen ahoppen mentioned this pull request Jul 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnbarham bnbarham bnbarham approved these changes

@kimdv kimdv kimdv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahoppen @bnbarham @kimdv