Don’t generate BasicFormat+Extensions.swift and SyntaxClassifcation.swift #1915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
ahoppen
force-pushed
the
ahoppen/less-generation
branch
from
223365b to
8ffd59a
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
bnbarham
approved these changes
Jul 18, 2023
| @@ -164,7 +164,43 @@ open class BasicFormat: SyntaxRewriter { | |||
|
|
|||
| /// Whether a leading newline on `token` should be added. | |||
| open func requiresIndent(_ node: some SyntaxProtocol) -> Bool { | |||
| return node.requiresIndent | |||
There was a problem hiding this comment.
The nice thing about this being generated is that when a node is added, isIndented is right in the constructor and would hopefully have some thought put into it. Where as now you have to know to also update BasicFormat. Maybe that's fine (it's a similar case for the whitespace now), but seems worth mentioning.
There was a problem hiding this comment.
That’s a price I’m willing to pay for the reduced complexity. And I don’t really expect many new nodes that require indentation anyway 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of generating these files, we can just define them directly.
Also: Remove a couple of unused properties in
TokenSpec.