Skip to content

[5.9] Display actual expanded source, not expected source #1918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2023

Conversation

JosephDuffy
Copy link
Contributor

@JosephDuffy JosephDuffy commented Jul 17, 2023

  • Explanation: When assertMacroExpansion fails, it incorrectly displayed the expected source as the expanded source.
  • Scope: The assertMacroExpansion test function
  • Risk: Very low, only changes the description in case of an XCTFail
  • Testing: Tested manually
  • Issue: n/a
  • Reviewer: @ahoppen on Display actual expanded source, not expected source #1917

@JosephDuffy JosephDuffy requested a review from ahoppen as a code owner July 17, 2023 19:50
@ahoppen ahoppen changed the title Display actual expanded source, not expected source [5.9] Display actual expanded source, not expected source Jul 18, 2023
@ahoppen
Copy link
Member

ahoppen commented Jul 18, 2023

@swift-ci Please test

@ahoppen ahoppen requested a review from bnbarham July 18, 2023 14:56
@ahoppen ahoppen merged commit f1246ff into swiftlang:release/5.9 Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants