Introduce peek(isAt:)
#1942
Introduce peek(isAt:)
#1942
Conversation
This makes it a lot easier to check if the next token is of a specific kind.
|
@swift-ci Please test |
| extension TokenConsumer { | ||
| /// Returns whether the next (peeked) token matches `spec` | ||
| @inline(__always) | ||
| mutating func peek(isAt spec: TokenSpec) -> Bool { |
There was a problem hiding this comment.
Thoughts on just at instead of isAt? next could work as well. Or maybe nextAt(_:) instead of peek to match at(_:)?
There was a problem hiding this comment.
I deliberately decided against peek(at:) because we already have peek(at offset: Int) in the lexer, which peeks offset bytes ahead, which has completely different semantics.
We could consider renaming peek to next altogether. I’m not sure how much of a term of art peek is in parsers in general and whether we should stick to it because of that reason though.
There was a problem hiding this comment.
Could also change peek(at offset: Int) to something else. You don't need to block the PR on this though, easy enough to rename peek(isAt:) if we want to after.
This makes it a lot easier to check if the next token is of a specific kind.