More renames of syntax nodes #1949
Conversation
|
@swift-ci Please test macOS |
ahoppen
changed the title
|
swiftlang/swift-stress-tester#244 @swift-ci Please test macOS |
| @@ -738,9 +738,9 @@ public let EXPR_NODES: [Node] = [ | |||
| kind: .token(choices: [.token(tokenKind: "BackslashToken")]) | |||
| ), | |||
| Child( | |||
| name: "RawStringDelimiter", | |||
| name: "Pounds", | |||
There was a problem hiding this comment.
Honestly I think I prefer RawStringDelimiter. That's mostly because pounds just reads weirdly to me though.
There was a problem hiding this comment.
Discussed offline, with pounds, I think is easier to understand what this represents.
| @@ -1676,7 +1686,8 @@ public let EXPR_NODES: [Node] = [ | |||
| kind: .token(choices: [.keyword(text: "switch")]) | |||
| ), | |||
| Child( | |||
| name: "Expression", | |||
| name: "Subject", | |||
There was a problem hiding this comment.
Reference calls this the "control expression" FWIW
There was a problem hiding this comment.
The compiler calls it “subject”. I think I prefer “subject”.
|
swiftlang/swift-format#572 @swift-ci Please test macOS |
|
swiftlang/swift-format#572 @swift-ci Please test Linux |
|
swiftlang/swift-format#572 @swift-ci Please test Windows |
1 similar comment
|
swiftlang/swift-format#572 @swift-ci Please test Windows |
No description provided.