Fix bug that caused the rootId of a node to not be updated if it was created by a replacing* function #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…created by a replacing* function When creating a node using e.g. `replacingTrailingTrivia`, it would still have the same the same rootId as before. Because of this `SyntaxRewriter` would not detect the node as having changed, thus failing to replace it in the rewritten tree.
|
@swift-ci Please test |
akyrtzi
approved these changes
Jan 29, 2020
|
Could you also create a PR on swift-5.2 branch? |
adevress
pushed a commit
to adevress/swift-syntax
that referenced
this pull request
Jan 14, 2024
Correct version string for `--version` flag (master)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a node using e.g.
replacingTrailingTrivia, it would still have the same the same rootId as before. Because of thisSyntaxRewriterwould not detect the node as having changed, thus failing to replace it in the rewritten tree.