Skip to content

[Gardening] Update all Python scripting to conform to the style guidelines enforced by the black code-formatting tool. #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2020

Conversation

Rostepher
Copy link
Contributor

@Rostepher Rostepher commented Feb 2, 2020

The black tool is the Python Software Foundation's blessed formatting tool in the same spirit as gofmt. It's opinionated, but keeps all code consistent automatically. This change is completely non-functional and merely adds a proper flake8 config file and runs the black tool over the build-script.py and lit_tests/lit.cfg files.

Note: black is MIT licensed.

…lines enforced by the black code-formatting tool.
@Rostepher Rostepher requested review from akyrtzi and ahoppen February 2, 2020 09:48
@Rostepher
Copy link
Contributor Author

@swift-ci please test

@Rostepher Rostepher requested a review from shahmishal February 2, 2020 09:52
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

As a general direction: Are you planning to add CI testing to enforce the code style?

@Rostepher
Copy link
Contributor Author

@ahoppen I would love to add that in the future. We could enforce flake8 and black on all the Python sources. But for now this is more a manual transition.

@Rostepher Rostepher merged commit 056a9d9 into swiftlang:master Feb 2, 2020
@Rostepher Rostepher deleted the black-style-conformance branch February 2, 2020 20:37
adevress pushed a commit to adevress/swift-syntax that referenced this pull request Jan 14, 2024
Allow indenting case statements relative to the containing switch block
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants