Skip to content

Limit conditions for inferencing a possible FuncDecl #2149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions Sources/SwiftParser/Declarations.swift
Original file line number Diff line number Diff line change
Expand Up @@ -281,9 +281,10 @@ extension Parser {
)
}

let isProbablyFuncDecl = self.at(.identifier, .wildcard) || self.at(anyIn: Operator.self) != nil

if isProbablyFuncDecl {
let isPossibleFuncIdentifier = self.at(.identifier, .wildcard)
let isPossibleFuncParen = self.peek(isAt: .leftParen, .binaryOperator)
// Treat operators specially because they're likely to be functions.
if (isPossibleFuncIdentifier && isPossibleFuncParen) || self.at(anyIn: Operator.self) != nil {
return RawDeclSyntax(self.parseFuncDeclaration(attrs, .missing(.keyword(.func))))
}
}
Expand Down
80 changes: 65 additions & 15 deletions Tests/SwiftParserTest/DeclarationTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,61 @@ final class DeclarationTests: ParserTestCase {
type: IdentifierTypeSyntax(name: .identifier("Int"))
)
)

assertParse(
"""
class MyClass {
1️⃣foo()
}
""",
diagnostics: [
DiagnosticSpec(
locationMarker: "1️⃣",
message: "expected 'func' in function",
fixIts: ["insert 'func'"]
)
],
fixedSource: """
class MyClass {
func foo()
}
"""
)

assertParse(
"""
class MyClass {
1️⃣foo<Int>2️⃣
}
""",
diagnostics: [
DiagnosticSpec(
locationMarker: "1️⃣",
message: "expected 'func' in function",
fixIts: ["insert 'func'"]
),
DiagnosticSpec(locationMarker: "2️⃣", message: "expected parameter clause in function signature", fixIts: ["insert parameter clause"]),
],
fixedSource: """
class MyClass {
func foo<Int>()
}
"""
)

assertParse(
"""
class MyClass {
1️⃣foo
}
""",
diagnostics: [
DiagnosticSpec(
locationMarker: "1️⃣",
message: "unexpected code 'foo' in class"
)
]
)
}

func testFuncAfterUnbalancedClosingBrace() {
Expand Down Expand Up @@ -1822,19 +1877,17 @@ final class DeclarationTests: ParserTestCase {
"""
struct Foo {
#1️⃣
2️⃣myMacroName3️⃣
2️⃣myMacroName
}
""",
diagnostics: [
DiagnosticSpec(locationMarker: "1️⃣", message: "expected identifier in macro expansion", fixIts: ["insert identifier"]),
DiagnosticSpec(locationMarker: "2️⃣", message: "expected 'func' in function", fixIts: ["insert 'func'"]),
DiagnosticSpec(locationMarker: "3️⃣", message: "expected parameter clause in function signature", fixIts: ["insert parameter clause"]),
DiagnosticSpec(locationMarker: "2️⃣", message: "unexpected code 'myMacroName' in struct"),
],
fixedSource: """
struct Foo {
#<#identifier#>
func
myMacroName()
myMacroName
}
"""
)
Expand Down Expand Up @@ -2360,27 +2413,24 @@ final class DeclarationTests: ParserTestCase {
class A ℹ️{
1️⃣^
}
unowned 2️⃣B 3️⃣{
}4️⃣
unowned 2️⃣B {
}
""",
diagnostics: [
DiagnosticSpec(locationMarker: "1️⃣", message: "unexpected code before modifier"),
DiagnosticSpec(locationMarker: "2️⃣", message: "expected 'func' in function", fixIts: ["insert 'func'"]),
DiagnosticSpec(locationMarker: "3️⃣", message: "expected parameter clause in function signature", fixIts: ["insert parameter clause"]),
DiagnosticSpec(
locationMarker: "4️⃣",
message: "expected '}' to end class",
notes: [NoteSpec(message: "to match this opening '{'")],
fixIts: ["insert '}'"]
locationMarker: "2️⃣",
message: "expected declaration and '}' after 'unowned' modifier",
fixIts: ["insert declaration and '}'"]
),
],
fixedSource:
"""
class A {
^
}
unowned func B() {
}
unowned <#declaration#>
}B {
}
"""
)
Expand Down