-
Notifications
You must be signed in to change notification settings - Fork 440
Add more documentation do Syntax nodes #2153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dc8e6a7
to
f5ba1b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few suggestions from my side ...
f5ba1b1
to
5b86298
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good to me. Thanks @kimdv. I wonder if cases like
The `actor` keyword
can be handled as part of #1987
CC @natikgadzhi
@ahoppen @kimdv yep! I haven't jumped into #1987 fully yet, but it does feel like when a child has just one / few possible kinds or specific tokens — we could generate documentation on those automatically based on those kinds, without hard-coding the specific doc string for each child. Thank you for nudging me here! <3 |
Will remove those cases again. |
a87c97a
to
3f9548b
Compare
40ae2eb
to
71196c6
Compare
@ahoppen added more documentation. Can also add more in a separate PR if you want? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, let’s merge this. Just looks like the change to CodeGeneration/Package.swift is unrelated.
71196c6
to
8095caf
Compare
@swift-ci please test |
@swift-ci please test windows |
Part of #1528
I've started to add more documentation to the syntax nodes.
Some of them are pretty trivial and not sure if that is the path we want.
Like the effect specifiers, we could generate them if we wan't them.
I think they give some value specially places where we use
asyncSpecifier
etc. Here are two valid options.We could generate
Then they could be able to click on them and navigate to it.
When generating this, we could make rule, that if we define the documentation then it overrules the generated ones