Skip to content

Fix a string interpolation error in CodeGeneration #2159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Fix a string interpolation error in CodeGeneration #2159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions CodeGeneration/Sources/generate-swift-syntax/templates/swiftsyntax/SyntaxBaseNodesFile.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,7 @@ let syntaxBaseNodesFile = SourceFileSyntax(leadingTrivia: copyrightHeader) {
}

leafProtocolDecl(type: node.kind.leafProtocolType, inheritedType: node.kind.protocolType)
leafProtocolExtension(type: node.kind.leafProtocolType, inheritedType: node.kind.protocolType)
}

try! ExtensionDeclSyntax(
Expand Down Expand Up @@ -350,18 +351,25 @@ let syntaxBaseNodesFile = SourceFileSyntax(leadingTrivia: copyrightHeader) {
}

leafProtocolDecl(type: "_LeafSyntaxNodeProtocol", inheritedType: "SyntaxProtocol")
leafProtocolExtension(type: "_LeafSyntaxNodeProtocol", inheritedType: "SyntaxProtocol")
}

private func leafProtocolDecl(type: TypeSyntax, inheritedType: TypeSyntax) -> DeclSyntax {
DeclSyntax(
#"""
"""
/// Protocol that syntax nodes conform to if they don't have any semantic subtypes.
/// These are syntax nodes that are not considered base nodes for other syntax types.
///
/// Syntax nodes conforming to this protocol have their inherited casting methods
/// deprecated to prevent incorrect casting.
public protocol \#(type): \#(inheritedType) {}
public protocol \(type): \(inheritedType) {}
"""
)
}

private func leafProtocolExtension(type: TypeSyntax, inheritedType: TypeSyntax) -> DeclSyntax {
DeclSyntax(
#"""
public extension \#(type) {
/// Checks if the current leaf syntax node can be cast to a different specified type.
///
Expand Down
12 changes: 12 additions & 0 deletions Sources/SwiftSyntax/generated/SyntaxBaseNodes.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,7 @@ public extension _LeafDeclSyntaxNodeProtocol {
func `is`<S: DeclSyntaxProtocol>(_ syntaxType: S.Type) -> Bool {
return false
}


/// Attempts to cast the current leaf syntax node to a different specified type.
///
Expand All @@ -286,6 +287,7 @@ public extension _LeafDeclSyntaxNodeProtocol {
func `as`<S: DeclSyntaxProtocol>(_ syntaxType: S.Type) -> S? {
return nil
}


/// Force-casts the current leaf syntax node to a different specified type.
///
Expand Down Expand Up @@ -591,6 +593,7 @@ public extension _LeafExprSyntaxNodeProtocol {
func `is`<S: ExprSyntaxProtocol>(_ syntaxType: S.Type) -> Bool {
return false
}


/// Attempts to cast the current leaf syntax node to a different specified type.
///
Expand All @@ -602,6 +605,7 @@ public extension _LeafExprSyntaxNodeProtocol {
func `as`<S: ExprSyntaxProtocol>(_ syntaxType: S.Type) -> S? {
return nil
}


/// Force-casts the current leaf syntax node to a different specified type.
///
Expand Down Expand Up @@ -862,6 +866,7 @@ public extension _LeafPatternSyntaxNodeProtocol {
func `is`<S: PatternSyntaxProtocol>(_ syntaxType: S.Type) -> Bool {
return false
}


/// Attempts to cast the current leaf syntax node to a different specified type.
///
Expand All @@ -873,6 +878,7 @@ public extension _LeafPatternSyntaxNodeProtocol {
func `as`<S: PatternSyntaxProtocol>(_ syntaxType: S.Type) -> S? {
return nil
}


/// Force-casts the current leaf syntax node to a different specified type.
///
Expand Down Expand Up @@ -1143,6 +1149,7 @@ public extension _LeafStmtSyntaxNodeProtocol {
func `is`<S: StmtSyntaxProtocol>(_ syntaxType: S.Type) -> Bool {
return false
}


/// Attempts to cast the current leaf syntax node to a different specified type.
///
Expand All @@ -1154,6 +1161,7 @@ public extension _LeafStmtSyntaxNodeProtocol {
func `as`<S: StmtSyntaxProtocol>(_ syntaxType: S.Type) -> S? {
return nil
}


/// Force-casts the current leaf syntax node to a different specified type.
///
Expand Down Expand Up @@ -1425,6 +1433,7 @@ public extension _LeafTypeSyntaxNodeProtocol {
func `is`<S: TypeSyntaxProtocol>(_ syntaxType: S.Type) -> Bool {
return false
}


/// Attempts to cast the current leaf syntax node to a different specified type.
///
Expand All @@ -1436,6 +1445,7 @@ public extension _LeafTypeSyntaxNodeProtocol {
func `as`<S: TypeSyntaxProtocol>(_ syntaxType: S.Type) -> S? {
return nil
}


/// Force-casts the current leaf syntax node to a different specified type.
///
Expand Down Expand Up @@ -1754,6 +1764,7 @@ public extension _LeafSyntaxNodeProtocol {
func `is`<S: SyntaxProtocol>(_ syntaxType: S.Type) -> Bool {
return false
}


/// Attempts to cast the current leaf syntax node to a different specified type.
///
Expand All @@ -1765,6 +1776,7 @@ public extension _LeafSyntaxNodeProtocol {
func `as`<S: SyntaxProtocol>(_ syntaxType: S.Type) -> S? {
return nil
}


/// Force-casts the current leaf syntax node to a different specified type.
///
Expand Down