[509] Delete the linkage tests #2191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The linkage tests have been causing more issues than they caught issues. And really what we want to test, is that the libraries built for the compiler using CMake don’t have any unexpected dependencies – it doesn’t really matter if the swift-syntax package itself gains a new link dependency. Furthermore, the test was only checking `SwiftSyntax`, `SwiftParser` and `SwiftSyntaxBuilder` and was missing e.g. `SwiftSyntaxMacros`. We should properly test that no dylibs in the toolchain have unintended linkages as part of integration testing in the apple/swift repo.
bnbarham
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #2189 to 509.
The linkage tests have been causing more issues than they caught issues. And really what we want to test, is that the libraries built for the compiler using CMake don’t have any unexpected dependencies – it doesn’t really matter if the swift-syntax package itself gains a new link dependency.
Furthermore, the test was only checking
SwiftSyntax,SwiftParserandSwiftSyntaxBuilderand was missing e.g.SwiftSyntaxMacros.We should properly test that no dylibs in the toolchain have unintended linkages as part of integration testing in the apple/swift repo.