-
Notifications
You must be signed in to change notification settings - Fork 440
build: explicitly specify python interpreter #222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This ensures that the build system can control the python interpreter rather than relying on the `PATH` or the shebang.
@swift-ci please test |
This can be merged separately as it has no dependencies on the build system it will simply ensure that the python interpreter used to invoke |
Hmm, this is not enough, in swift-syntax repo we commit the gyb-generated files into the repo. |
Hmm, lets actually do that in a follow up change that can be committed in sync. master hasn't yet switched to python3 yet. This is still a bit worrisome since there is no way for us to currently ensure that macOS builds with python3 as there is an issue with some of the builders not finding python3 always (maybe @shahmishal remembers the details here) and we can fallback to python2 if python3 is not found. |
We could potentially pick a specific hash algorithm to make it python version independent. |
We should use |
@akyrtzi - I like that idea! That certainly would make the transition much simpler. Would you happen to have any specific hash in mind? Would SHA1 be reasonable enough? That is amongst the supported hashes in the Intel SHA extensions enabling a hardware accelerated variant to be implemented on platforms. |
Any that is available in all platforms would do, SHA1 is fine. |
Specify the type of decl to rename in AlwaysUseLowerCamelCase.
This ensures that the build system can control the python interpreter
rather than relying on the
PATH
or the shebang.