Add some more documentaiton on assertParse
#2236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
force-pushed
the
ahoppen/assertion-documentation
branch
from
b081d9d to
6670fb2
Compare
bnbarham
reviewed
Sep 25, 2023
| """ | ||
| A mutation of the original test case failed to round-trip. | ||
|
|
||
| To debug the failure, add a new `assertParse` test with the mutated source as input. |
There was a problem hiding this comment.
You could add this part to additionalInfo maybe? Or do you think it could be missed if it was after the diff?
| /// subtree of that structure. | ||
| /// 5. Mutates the test input by flipping each token's presence (ie. for every | ||
| /// token, remove it from the input if it is present in the parsed tree and | ||
| /// synthesize a missing tokens into the input) and verifies that this |
There was a problem hiding this comment.
Suggested change
| /// synthesize a missing tokens into the input) and verifies that this | |
| /// synthesize any missing tokens into the input) and verifies that this |
There was a problem hiding this comment.
This is intentionally a because only a single to ken will be synthesized not all of them.
There was a problem hiding this comment.
How about:
/// 5. Mutates the test input by flipping each token's presence (ie. for every
/// token, either remove it from the input if it is present in the parsed tree or
/// synthesize it if it was missing) and verifies that this
kimdv
approved these changes
Sep 25, 2023
ahoppen
force-pushed
the
ahoppen/assertion-documentation
branch
2 times, most recently
from
6b79cf4 to
7f4de92
Compare
|
@swift-ci Please test |
ahoppen
force-pushed
the
ahoppen/assertion-documentation
branch
from
7f4de92 to
1c852df
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
bnbarham
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.