Skip to content

Autodiff updates for enabling accessor derivatives … #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 2, 2020

Conversation

ematejska
Copy link
Contributor

@ematejska ematejska commented Jul 1, 2020

This corresponds to swiftlang/swift#32614
Update gyb-generated files.

@ematejska ematejska requested a review from akyrtzi July 1, 2020 19:33
Copy link
Contributor

@akyrtzi akyrtzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to test the swift PR together along with this one.

@ematejska
Copy link
Contributor Author

Kicking off the swift testing now.

@ematejska
Copy link
Contributor Author

Please test with:
swiftlang/swift#32614
@swift-ci please test mac os platform

@ematejska
Copy link
Contributor Author

@akyrtzi Could you kick off the testing? The swiftlang/swift#32614 testing passed with a reference to this pull request.

@akyrtzi
Copy link
Contributor

akyrtzi commented Jul 1, 2020

If ready, ping me and I'll merge both at the same time.

@ematejska
Copy link
Contributor Author

ematejska commented Jul 2, 2020

@akyrtzi Yes, ready! (Hi BTW, look at me I'm contributing to swift-syntax :). The commits for swiftlang/swift#32614 need to be squashed at merge.

@akyrtzi akyrtzi merged commit 7558636 into swiftlang:master Jul 2, 2020
@akyrtzi
Copy link
Contributor

akyrtzi commented Jul 2, 2020

Hi BTW, look at me I'm contributing to swift-syntax :)

Welcome back to Swift! 😀

adevress pushed a commit to adevress/swift-syntax that referenced this pull request Jan 14, 2024
Don't require a returns comment for functions that never return.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants