Skip to content

[5.10] Remove WildcardPattern.typeAnnotation #2402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Dec 12, 2023

Cherry-pick #2395 into release/5.10

  • Explanation: WildPatternSyntax.typeAnnotation was added by accident. It should have never been a part of WildcardPatternSyntax.
  • Scope: SwiftSyntax tree API
  • Risk: Low. SwiftParser never set it.
  • Testing: Passes the current test suite
  • Issues: N/A
  • Reviewer: Alex Hoppen (@ahoppen)

@rintaro rintaro requested a review from ahoppen as a code owner December 12, 2023 00:41
@rintaro
Copy link
Member Author

rintaro commented Dec 12, 2023

@swift-ci Please test

Type annotation has never been a part of `wildcard-pattern`.

(cherry picked from commit 3ad670b)
@rintaro rintaro force-pushed the 5.10-wildcardpattern-typeannotation branch from 98d5998 to c042bab Compare December 12, 2023 18:14
@rintaro
Copy link
Member Author

rintaro commented Dec 12, 2023

@swift-ci Please test

@rintaro
Copy link
Member Author

rintaro commented Dec 12, 2023

@swift-ci Please test Windows

@rintaro rintaro merged commit 15064cc into swiftlang:release/5.10 Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants