Skip to content

Added TriviaPiece.isComment #2469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 8, 2024
Merged

Added TriviaPiece.isComment #2469

merged 4 commits into from
Feb 8, 2024

Conversation

vinu-vanjari
Copy link
Contributor

@vinu-vanjari vinu-vanjari commented Feb 5, 2024 •
edited
Loading

Resolves #2452

Matejkob
Matejkob reviewed Feb 5, 2024
View reviewed changes
Copy link
Contributor

@Matejkob Matejkob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR, and welcome to the project! 🎉 I've reviewed your changes and left a few ideas for discussion. I'm looking forward to your thoughts and contributions. Welcome aboard!

@vinu-vanjari vinu-vanjari force-pushed the TriviaPiece.isComment branch from 2e5f93a to a22f832 Compare February 5, 2024 18:54
@vinu-vanjari
Copy link
Contributor Author

@Matejkob ,
thank you very much for the warm welcome, patient comments and taking your time to guide me.
your comments are very helpful and enlightening!!

This time, I have changed CodeGeneration template file which then generates TriviaPieces.swift file in Swift-Syntax.
I referred to isWhiteSpace and isSpaceOrTab implementations in the same generator template file.

Then, I ran code generation command which generated changes in Sources/SwiftSyntax/generated/TriviaPieces.swift

Looking forward to your feedback

@vinu-vanjari vinu-vanjari requested a review from Matejkob February 5, 2024 19:08
ahoppen
ahoppen reviewed Feb 5, 2024
View reviewed changes
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Looks good to me. Could you add an entry to the release notes?

@vinu-vanjari vinu-vanjari requested a review from ahoppen February 6, 2024 08:07
@ahoppen
Copy link
Member

ahoppen commented Feb 6, 2024

@swift-ci Please test

@ahoppen ahoppen enabled auto-merge February 6, 2024 21:38
@vinu-vanjari
Copy link
Contributor Author

@ahoppen Anything pending from my side? I can't see the full status of windows tests

@Matejkob
Copy link
Contributor

Matejkob commented Feb 8, 2024

@ahoppen Anything pending from my side? I can't see the full status of windows tests

No need to be concerned about the Windows tests—they can occasionally encounter internal issues. Everything's fine on your end. Thanks for your contribution!

@bnbarham
Copy link
Contributor

bnbarham commented Feb 8, 2024

@swift-ci please test Windows platform

@ahoppen ahoppen merged commit d364cac into swiftlang:main Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahoppen ahoppen ahoppen approved these changes

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham is a code owner

@Matejkob Matejkob Awaiting requested review from Matejkob

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add TriviaPiece.isComment
4 participants
@vinu-vanjari @ahoppen @Matejkob @bnbarham