[Test] Speculatively fix a non-deterministic issue #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
nkcsgexi
approved these changes
Nov 4, 2020
Somehow, `deinit` isn't called deterministically. Instead of using `deinit` to print out the summary, use `finalize()` which is intended to be finalize the diagnostics. Fixes rdar://problem/71046813
rintaro
force-pushed
the
test-rdar71047138
branch
from
c30abf8 to
1b6dac3
Compare
|
@swift-ci Please test |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
adevress
pushed a commit
to adevress/swift-syntax
that referenced
this pull request
Jan 14, 2024
build: use Foundation instead of C for the environment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow,
deinitisn't called deterministically. Instead of usingdeinitto print out the summary, usefinalize()which is intended to finalize the diagnostics.Fixes rdar://problem/71046813