Add representation and parser support for the @isolated type attribute #2472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
ahoppen
reviewed
Feb 5, 2024
rjmccall
force-pushed
the
add-isolated-any
branch
from
9cd04e2 to
6855966
Compare
|
@swift-ci Please test |
rjmccall
force-pushed
the
add-isolated-any
branch
2 times, most recently
from
ab536f0 to
2d15f31
Compare
rjmccall
force-pushed
the
add-isolated-any
branch
from
2d15f31 to
6c92d16
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows platform |
rjmccall
force-pushed
the
add-isolated-any
branch
2 times, most recently
from
4d4e241 to
2873541
Compare
|
@swift-ci Please test |
ahoppen
approved these changes
Feb 6, 2024
|
@swift-ci Please test Windows |
As part of this, I had to update the attribute parser to not recurse into the full parseType routine since that would attempt to parse attributes again right after the `@`. Doing so allows some genuinely bizarre constructs that we obviously don't want and will reject in semantic analysis anyway. For `@isolated` specifically, it creates an artificial parsing conflict with the `isolated` parameter specifier and possible future declaration modifier, just in case you wanted attributes to apply to your attributes.
rjmccall
force-pushed
the
add-isolated-any
branch
from
087f88f to
4683d94
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.