Mark all PluginMessageHandling symbols SPI #2489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
swiftlang/swift#71513 |
rintaro
force-pushed
the
pluginmessage-spi
branch
from
9796261 to
b1b282f
Compare
|
swiftlang/swift#71513 |
|
swiftlang/swift#71513 |
ahoppen
approved these changes
Feb 12, 2024
Release Notes/511.md
Outdated
| - All symbols in `SwiftSyntaxMacroExpansion` and `SwiftCompilerPluginMessageHandling` are now SPI | ||
| - Description: These modules are only intended to be used from some internal components. Any other modules should not use them directly. | ||
| - Pull requrest: https://github.com/apple/swift-syntax/pull/2489 | ||
| - Micration staps: Stop using these modules. |
There was a problem hiding this comment.
Suggested change
| - Micration staps: Stop using these modules. | |
| - Migration staps: Stop using these modules. |
rintaro
force-pushed
the
pluginmessage-spi
branch
from
b1b282f to
e66961a
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
|
swiftlang/swift#71513 |
|
swiftlang/swift#71513 |
SwiftCompilerPluginMessageHandling are only intended to be used from internal modules like SwiftCompilerPlugin, or ASTGen and swift-plugin-server in swift repository. Make all the public symbols SPI so other third party modules don't accidentally use them.
rintaro
force-pushed
the
pluginmessage-spi
branch
from
e66961a to
31ea421
Compare
rintaro
changed the title
|
swiftlang/swift#71513 |
|
Scoped down to |
ahoppen
approved these changes
Apr 12, 2024
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SwiftCompilerPluginMessageHandlingis only intended to be used from internal modules likeSwiftCompilerPlugin, orASTGenandswift-plugin-serverin swift repository. Make all the public symbols SPI so other third party modules don't accidentally use it.