Skip to content

[6.0] Don’t add a space between private and ( #2591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[6.0] Don’t add a space between private and ( #2591

wants to merge 1 commit into from

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Apr 4, 2024

  • Explanation: BasicFormat was adding a space between private and ( in private(set), which started raising a warning with recent compilers: Extraneous whitespace between attribute name and '('; this is an error in Swift 6
  • Scope: Formatting of private(set)
  • Risk: Very low, very targeted fix
  • Testing: Added a test case
  • Issue: rdar://124569733
  • Reviewer: @bnbarham on Don’t add a space between private and ( #2590

@ahoppen ahoppen requested a review from bnbarham as a code owner April 4, 2024 16:45
@ahoppen
Copy link
Member Author

ahoppen commented Apr 4, 2024

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented Apr 4, 2024

Closing in favor of #2592

@ahoppen ahoppen closed this Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnbarham bnbarham bnbarham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahoppen @bnbarham