[6.0] Default to not requiring whitespace before (
#2595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are only a few cases where `(` should be preceded by a space: closure parameters, function types and tuples. Instead of defaulting to add whitespace before `(`, check for those cases and if we are not in one of them, don’t require whitespace. rdar://124569733
|
@swift-ci Please test |
bnbarham
approved these changes
Apr 10, 2024
ahoppen
added a commit
to ahoppen/swift
that referenced
this pull request
Apr 10, 2024
…#available` and `(` by SwiftSyntax anymore Companion of swiftlang/swift-syntax#2595
|
@swift-ci Please test |
ahoppen
added a commit
to ahoppen/swift
that referenced
this pull request
Apr 11, 2024
…#available` and `(` by SwiftSyntax anymore Companion of swiftlang/swift-syntax#2595
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(should be preceded by a space: closure parameters, function types and tuples. Instead of defaulting to add whitespace before(, check for those cases and if we are not in one of them, don’t require whitespace. This has become important since we diagnose a space between an attribute name an it’s opening(as a warning in Swift 5 and as an error in Swift 6 mode.BasicFormaton source code that contains a non-keyword token followed by(.(could break something apart from the cases that we have covered. And without this fix, a lot of code generated by macros does not compile in Swift 6 mode.(#2592