Skip to content

Move public from extension decl to each decl in the extension in generated files #2609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 20, 2024
Merged

Move public from extension decl to each decl in the extension in generated files #2609

merged 1 commit into from
Apr 20, 2024
+313 −313

Conversation

Matejkob
Copy link
Contributor

No description provided.

@Matejkob Matejkob marked this pull request as ready for review April 19, 2024 17:39
ahoppen
ahoppen approved these changes Apr 20, 2024
View reviewed changes
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏🏽

Similar to #2609, could you also create a cherry-pick PR of this to release/6.0 to reduce merge conflicts for other PRs that are being cherry picked?

@ahoppen
Copy link
Member

ahoppen commented Apr 20, 2024

@swift-ci Please test

@ahoppen ahoppen enabled auto-merge April 20, 2024 04:54
@kimdv
Copy link
Contributor

kimdv commented Apr 20, 2024

@swift-ci please test windows

@ahoppen ahoppen merged commit 4824d4d into swiftlang:main Apr 20, 2024
@Matejkob Matejkob mentioned this pull request Apr 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahoppen ahoppen ahoppen approved these changes

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Matejkob @ahoppen @kimdv