[6.0] Remove public from the extension declaration and add it to each declaration in the extension
#2611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ration in the extension (cherry picked from commit ce8b9cd) # Conflicts: # Sources/SwiftIDEUtils/Syntax+Classifications.swift # Sources/SwiftSyntax/SyntaxProtocol.swift # Sources/SwiftSyntax/Utils.swift
|
To minimize the risk of this cherry-pick I have created one more PR with only changes made by |
|
@swift-ci please test |
bnbarham
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #2602 into release/6.0
Explanation: In Remove
publicfrom the extension declaration and add it to each declaration in the extension #2602, we refactored code by using theswift-formatruleNoAccessLevelOnExtensionDeclarationand manually chose only changes with thepublicaccess level modifier. To reduce the risk of merge conflicts in cherry-picks intorelease/6.0, we are merging this refactored code into this branch as well.Scope: Entire codebase.
Risk: Medium. During the cherry-pick, we encountered conflicts in the following files:
Sources/SwiftIDEUtils/Syntax+Classifications.swiftSources/SwiftSyntax/SyntaxProtocol.swiftSources/SwiftSyntax/Utils.swiftThe risk is that there are some extension members that don't have the
publicmodifier transferred from their extension declaration.Testing: Passes current test suite.
Issue: N/A
Reviewer: Alex Hoppen (@ahoppen)