Skip to content

[CompilerPlugin] Sink error exit logic to "message listener" #2631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2024
Merged

[CompilerPlugin] Sink error exit logic to "message listener" #2631

merged 1 commit into from
Apr 29, 2024

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Apr 29, 2024 •
edited
Loading

And print the error to stderr manually, instead of fatalError(). We don't want to print the file name / line number for this.

@rintaro
Copy link
Member Author

rintaro commented Apr 29, 2024

@swift-ci Please test

@rintaro rintaro mentioned this pull request Apr 29, 2024
Merged
@rintaro rintaro merged commit 98c5144 into swiftlang:main Apr 29, 2024
@rintaro rintaro mentioned this pull request May 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahoppen ahoppen ahoppen approved these changes

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rintaro @ahoppen