Skip to content

[6.0][CompilerPlugin] Updates after Foundation removal #2632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 29, 2024

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Apr 29, 2024

Cherry-pick #2618 into release/6.0

  • Explanation: Several cleanups and code moving after the Foundation removal in [6.0][CompilerPlugin] Remove Foundation dependency #2619 . The main change is that PluginMesageConnection is now moved to SwiftCompilerPluginMessageHandling module so it can be usable from other components e.g. swift-plugin-server.
  • Scope: Macro plugins
  • Risk: Mid? Somewhat large code moving.
  • Testing: Passes current test suite
  • Issue: N/A
  • Reivewer: Alex Hoppen (@ahoppen) Hamish Knight (@hamishknight)

rintaro added 4 commits April 29, 2024 11:20
Headers are now in 'swiftsyntax' subdirectory to avoid file name conflicts
with libc. e.g. '#include <_stdio.h>' referenced from C++ compiler code
which might pick up '_SwiftSyntaxCShims/include/_stdio.h'

(cherry picked from commit 6dc8d43)
So that other modules (e.g. swift-plugin-server can use it)
Renamed to 'StandardIOMessageConnection'

(cherry picked from commit 3a5ff0e)
@rintaro
Copy link
Member Author

rintaro commented Apr 29, 2024

@swift-ci Please test

@rintaro rintaro merged commit 5e8205b into swiftlang:release/6.0 Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants