Skip to content

[6.0] Mark MacroSpec & SourceLocationConverter as Sendable #2681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 12, 2024
Merged

[6.0] Mark MacroSpec & SourceLocationConverter as Sendable #2681

merged 2 commits into from
Jun 12, 2024

Conversation

j-f1
Copy link
Contributor

@j-f1 j-f1 commented Jun 12, 2024 •
edited by ahoppen
Loading

  • Explanation: SourceLocationConverter and MacroSpec were not marked as Sendable, which made it harder to use them in Swift 6 mode. The types are already conceptually sendable, so we should mark them as Sendable.
  • Scope: Adding Sendable conformance
  • Risk: Very low, just adding a protocol conformance
  • Testing: n/a
  • Issue: n/a
  • Reviewer: @ahoppen on Make SourceLocationConverter Sendable #2675 and Mark MacroSpec as Sendable #2679.

@j-f1 j-f1 requested review from ahoppen and bnbarham as code owners June 12, 2024 15:33
@j-f1
Copy link
Contributor Author

j-f1 commented Jun 12, 2024

@swift-ci please test

@ahoppen ahoppen enabled auto-merge June 12, 2024 17:29
@ahoppen ahoppen merged commit 9c9d158 into release/6.0 Jun 12, 2024
3 checks passed
@ahoppen ahoppen deleted the jed/cherry-pick-sendables branch June 12, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnbarham bnbarham bnbarham approved these changes

@ahoppen ahoppen Awaiting requested review from ahoppen ahoppen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@j-f1 @bnbarham @ahoppen