Skip to content

[6.0] Mark FormatMode as Sendable #2735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2024
Merged

[6.0] Mark FormatMode as Sendable #2735

merged 1 commit into from
Jul 18, 2024

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Jul 17, 2024

  • Explanation: Mark FormatMode as Sendable
  • Risk: Low, just adds a Sendable conformance to a type that’s obviously sendable
  • Testing: n/a
  • Issue: n/a
  • Reviewer: @bnbarham

@ahoppen ahoppen requested a review from bnbarham July 17, 2024 18:45
@ahoppen ahoppen requested a review from DougGregor as a code owner July 17, 2024 18:45
@ahoppen
Copy link
Member Author

ahoppen commented Jul 17, 2024

@swift-ci Please test

@ahoppen ahoppen merged commit ed23a17 into swiftlang:release/6.0 Jul 18, 2024
3 checks passed
@ahoppen ahoppen deleted the 6.0/formatmode-sendable branch July 18, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnbarham bnbarham bnbarham approved these changes

@DougGregor DougGregor Awaiting requested review from DougGregor DougGregor is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahoppen @bnbarham