Skip to content

Make tokens public #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2021
Merged

Conversation

kimdv
Copy link
Contributor

@kimdv kimdv commented Apr 20, 2021

#268 (comment)

Making tokens public.

Waiting for #268 to be merged

@kimdv kimdv force-pushed the kimdv/make-tokens-public branch from 762a4b9 to 900d268 Compare April 22, 2021 13:40
@kimdv kimdv force-pushed the kimdv/make-tokens-public branch from 900d268 to a17b6ed Compare April 22, 2021 13:54
@kimdv kimdv marked this pull request as ready for review April 22, 2021 13:54
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think the test cases look a lot cleaner now already.

@ahoppen
Copy link
Member

ahoppen commented Apr 22, 2021

@swift-ci Please test

@kimdv
Copy link
Contributor Author

kimdv commented Apr 23, 2021

Yes! They look way more clean now 😁

@ahoppen ahoppen merged commit 547a776 into swiftlang:main Apr 23, 2021
@kimdv kimdv deleted the kimdv/make-tokens-public branch April 23, 2021 10:44
adevress pushed a commit to adevress/swift-syntax that referenced this pull request Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants