Support body macros that don’t return any statements #2775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
ahoppen
force-pushed
the
empty-body-macro
branch
from
19b5dec to
60d49f3
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
rintaro
reviewed
Aug 7, 2024
| func f() {} | ||
| """, | ||
| expandedSource: """ | ||
| func f() {} |
There was a problem hiding this comment.
Is expected behavior is replacing the body in the original code to {}? If so, could you add some statements in the original source code?
There was a problem hiding this comment.
It’s expected to leave the body untouched. This matches the behavior of accessors
I updated the test.
Previously, when a body macro returned no statements, we would return an empty expansion and not add the braces in `collapse`. Fix that.
ahoppen
force-pushed
the
empty-body-macro
branch
from
60d49f3 to
777c126
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
rintaro
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when a body macro returned no statements, we would return an empty expansion and not add the braces in
collapse. Fix that.